Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: Add enableShared/enableStatic arguments #72058

Merged
merged 1 commit into from Oct 30, 2019
Merged

R: Add enableShared/enableStatic arguments #72058

merged 1 commit into from Oct 30, 2019

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 27, 2019

Motivation for this change

Building libR.a for static linking.

Care was taken to not modify the derivation to trigger mass rebuilds with the default arguments.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti @timokau

@nh2 nh2 requested a review from peti as a code owner October 27, 2019 01:14
@nh2 nh2 changed the title R: Add enableShared/enableStatic arguments WIP: R: Add enableShared/enableStatic arguments Oct 27, 2019
@nh2 nh2 mentioned this pull request Oct 27, 2019
Merged
@nh2
Copy link
Contributor Author

nh2 commented Oct 27, 2019

@GrahamcOfBorg eval R

@nh2 nh2 changed the title WIP: R: Add enableShared/enableStatic arguments R: Add enableShared/enableStatic arguments Oct 27, 2019
peti
peti reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: why would you want to link R packages statically?

pkgs/applications/science/math/R/default.nix Outdated Show resolved Hide resolved
@nh2
Copy link
Contributor Author

nh2 commented Oct 30, 2019

Just out of curiosity: why would you want to link R packages statically?

Linking the R interpreter library statically would allow to create single binaries that can interpret R scripts. My own end goal for that is to be able to link the Haskell packages inline-r and H statically for static-haskell-nix.

@nh2
R: Add static argument.
edbe2d8 
R's autoconf does not use the normal configure flags for that.
@nh2
Copy link
Contributor Author

nh2 commented Oct 30, 2019

@GrahamcOfBorg build R

@ofborg ofborg bot requested review from timokau and peti October 30, 2019 11:04
@nh2
Copy link
Contributor Author

nh2 commented Oct 30, 2019

@peti Points addressed, please have another look :)

@peti peti merged commit 3bc7621 into NixOS:master Oct 30, 2019
@nh2 nh2 mentioned this pull request Nov 3, 2019
Open
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau Awaiting requested review from timokau

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @peti