stdenv: enable __structuredAttrs #72074
Conversation
ofborg
bot
added
6.topic: ruby
6.topic: stdenv
ofborg
bot
added
6.topic: erlang
6.topic: golang
6.topic: haskell
6.topic: lua
6.topic: nixos
6.topic: python
6.topic: xfce
globin
force-pushed
the
structured-attrs
branch
from
110ccd4
to
e7af4fe
Compare
|
Why not make the |
|
They need to be exported to be picked up by bintools-/cc-wrapper |
|
@globin we could require that they be lists, but then convert to strings (and quote!) ourselves. If that is not more churn, I think i might prefer that. |
|
I added |
| @@ -827,7 +827,7 @@ unpackFile() { | |||
| unpackPhase() { | |||
| runHook preUnpack | |||
|
|
|||
| if [ -z ${srcs+"${srcs[@]}"} ]; then | |||
| if [ -z ${srcs-"${srcs[@]}"} ]; then | |||
There was a problem hiding this comment.
${srcs-"${srcs[@]}"} expands to the first element of the srcs array; surely that’s not the intention.
| if [ -z ${srcs-"${srcs[@]}"} ]; then | |
| if [ ${#srcs[@]} = 0 ]; then |
github-actions
bot
removed
6.topic: stdenv
|
Is there still time to push this in? If not, is there any way this can be split up to make it more bearable to get this in? Otherwise this will be pushed forward indefinitely, I'm afraid. |
|
i think a way to help could be: |
|
what if we created a |
|
At least making it so this change can be split up seems like a good idea to me. I don't mind hacking at this, but doing everything at once is very hard to do, it'll also quickly have conflicts. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/cmakeflags-and-spaces-in-option-values/20170/2 |
|
#175649 has been merged |
__structuredAttrsis a nice feature, we want it enabled in stdenv!hydra jobset: https://hydra.nixos.org/jobset/nixpkgs/structured-attrs
related: NixOS/rfcs#13
Further information: https://nixos.mayflower.consulting/blog/2020/01/20/structured-attrs/
cc @Ericson2314 @matthewbauer