Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-nomad: init at 1.1.0 #72071

Merged
merged 1 commit into from Oct 27, 2019
Merged

pythonPackages.python-nomad: init at 1.1.0 #72071

merged 1 commit into from Oct 27, 2019

Conversation

xbreak
Copy link
Contributor

@xbreak xbreak commented Oct 27, 2019 •
edited

Python client library for Hashicorp Nomad

Motivation for this change

Useful library for interfacing Nomad from Python.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Edit:
Note: Tests are disabled because they are more like integration tests in that it requires a nomad agent running.

Notify maintainers

@xbreak
pythonPackages.python-nomad: init at 1.1.0
6c1db3b 
Python client library for Hashicorp Nomad
@mmahut
Copy link
Member

mmahut commented Oct 27, 2019

@GrahamcOfBorg build pythonPackages.python-nomad python3Packages.python-nomad

@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

nix-review builds for me, macos 10.13, but I can't say much more because tests disabled...

jonringer
jonringer approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
repo seems active enough

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72071
3 package were build:
python27Packages.python-nomad python37Packages.python-nomad python38Packages.python-nomad

@jonringer jonringer merged commit b24a32d into NixOS:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xbreak @mmahut @risicle @jonringer