Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opensc: CVE-2019-15945 and CVE-2019-15946 #72073

Merged
merged 2 commits into from Oct 27, 2019
Merged

opensc: CVE-2019-15945 and CVE-2019-15946 #72073

merged 2 commits into from Oct 27, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Oct 27, 2019 •
edited

Motivation for this change

Fixes #70119

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @erictapen

@mmahut mmahut requested a review from erictapen October 27, 2019 10:45
@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

nix-review happy for me, macos 10.13

@mmahut mmahut merged commit c75de8b into NixOS:release-19.09 Oct 27, 2019
@erictapen
Copy link
Member

Wow, thanks!

@ckauhaus
Copy link
Contributor

@mmahut: Is there any reason that you patched only 19.09? What on master?

@ckauhaus ckauhaus mentioned this pull request Oct 28, 2019
Closed
2 tasks
@mmahut
Copy link
Member Author

mmahut commented Oct 28, 2019

@ckauhaus working on it, been trying the 0.20 rc on master to see it makes sense, but I will patch master anyway so we are in the green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen Awaiting requested review from erictapen

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmahut @risicle @erictapen @ckauhaus