Code looks good to me

Thanks a lot for the suggestion. I'm not sure though if such an option is a good idea. Please wait before merging this until the community has reached a decision on redesigning the networking module after the networkd sprint in a few weeks. (Will announce it in Discourse later)

Also it is already sort of implemented by the fact that nixos-generate-config enables DHCP for each interface detected during install. This feature is in conflict with that.

I'm not sure though if such an option is a good idea.

me neither, especially the interface ..

It mainly solves my need short-term need and I wanted to register a requirement for pluggable network hardware (mainly desktops, laptops)

Also it is already sort of implemented by the fact that nixos-generate-config enables DHCP for each interface detected during install.

It doesn't work for usb modems and other runtime-pluggable hardware, especially since their interface names can change on re-plug.

I agree that it might be better to predicate on driver name, as you suggested on the previous PR.

useNetworkd is still marked as experimental, and defaulting to dhcp on a lot of interfaces leads to multiple problems, as explained in #71790 and linked issues.

Users that want above functionality regardless, can still accomplish the same functionality by manually setting something like that:

systemd.network.networks."10-dhcp-convenience" = {
  matchConfig.Name = "en* wl*";
  DHCP = "yes";
};

I'm also not in favour of introducing such an option. Providing some out of the box experience for installation media is definitely something we don't want to break, but I don't think this PR is the right way to go forward, especially given we want to redesign the provided options in the networkd sprint.

useNetworkd is still marked as experimental, and defaulting to dhcp on a lot of interfaces leads to multiple problems, as explained in #71790 and linked issues.

Yep, in fact, I think I can now get rid of a couple of linkConfig.Unmanaged for docker and virbr, now.
Thanks, for your work on this! @flokli