Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft: 2.1.5965 -> 2.1.7658 #72050

Merged
merged 1 commit into from Oct 28, 2019
Merged

minecraft: 2.1.5965 -> 2.1.7658 #72050

merged 1 commit into from Oct 28, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 26, 2019 •
edited

Motivation for this change

tried playing with friends, noticed it was out of date

used strace to determine that it needs both gtk2 and gtk3 in runtime path for it to work

gtk3 addition to closure:

$ nix path-info -Sh ./result
/nix/store/ibxwz2456xmjspnd85z8bqa9iwv99fai-minecraft-launcher-2.1.5965  622.5M
$ nix path-info -Sh ./result
/nix/store/y8fbsmql9nvpzlc76cyccfp7ggxcg1n4-minecraft-launcher-2.1.7658  675.2M
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor Author 

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72050
1 package were build:
minecraft

@ofborg ofborg bot requested review from cpages, ryantm and infinisil October 26, 2019 21:12
@infinisil
Copy link
Member

Awesome, does this need backporting?

@jonringer
Copy link
Contributor Author

probably

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 26, 2019
@mmahut
Copy link
Member

mmahut commented Oct 28, 2019

Looks good, thank you, do you mind opening a pull requests against release-19.09?

@mmahut mmahut merged commit 517dfa4 into NixOS:master Oct 28, 2019
@jonringer
Copy link
Contributor Author

sure

@jonringer jonringer deleted the bump-minecraft branch October 28, 2019 16:22
@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpages cpages Awaiting requested review from cpages

@ryantm ryantm Awaiting requested review from ryantm

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @infinisil @mmahut