Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-language-server: 0.28.3 -> 0.29.1 #72045

Merged
merged 3 commits into from Oct 28, 2019
Merged

pythonPackages.python-language-server: 0.28.3 -> 0.29.1 #72045

merged 3 commits into from Oct 28, 2019

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 26, 2019 •
edited

Motivation for this change

This fixes a failing test due to a pylint update.

Things done

Also requires a jedi update, and flake8 as a dependency.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from Mic92 October 26, 2019 20:15
jonringer
jonringer reviewed Oct 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to hold off on this, a lot of review failures are going to be fixed with #71893

[128 built (19 failed), 441 copied (3502.0 MiB), 1033.3 MiB DL]
error: build of '/nix/store/5hdi4isw03dqj4fqswqiadrxs9744bgb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72045
1 package are marked as broken and were skipped:
ihaskell

169 package failed to build:
python27Packages.pyspread python37Packages.azure-applicationinsights python37Packages.azure-batch python37Packages.azure-cli-core python37Packages.azure-eventgrid python37Packages.azure-graphrbac python37Packages.azure-keyvault python37Packages.azure-loganalytics python37Packages.azure-mgmt-advisor python37Packages.azure-mgmt-applicationinsights python37Packages.azure-mgmt-authorization python37Packages.azure-mgmt-batch python37Packages.azure-mgmt-batchai python37Packages.azure-mgmt-billing python37Packages.azure-mgmt-cdn python37Packages.azure-mgmt-cognitiveservices python37Packages.azure-mgmt-commerce python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-consumption python37Packages.azure-mgmt-containerinstance python37Packages.azure-mgmt-containerservice python37Packages.azure-mgmt-cosmosdb python37Packages.azure-mgmt-datafactory python37Packages.azure-mgmt-datalake-analytics python37Packages.azure-mgmt-datalake-store python37Packages.azure-mgmt-datamigration python37Packages.azure-mgmt-devspaces python37Packages.azure-mgmt-devtestlabs python37Packages.azure-mgmt-dns python37Packages.azure-mgmt-eventgrid python37Packages.azure-mgmt-eventhub python37Packages.azure-mgmt-hanaonazure python37Packages.azure-mgmt-iotcentral python37Packages.azure-mgmt-iothub python37Packages.azure-mgmt-iothubprovisioningservices python37Packages.azure-mgmt-keyvault python37Packages.azure-mgmt-loganalytics python37Packages.azure-mgmt-logic python37Packages.azure-mgmt-machinelearningcompute python37Packages.azure-mgmt-managementgroups python37Packages.azure-mgmt-managementpartner python37Packages.azure-mgmt-maps python37Packages.azure-mgmt-marketplaceordering python37Packages.azure-mgmt-media python37Packages.azure-mgmt-monitor python37Packages.azure-mgmt-msi python37Packages.azure-mgmt-network python37Packages.azure-mgmt-notificationhubs python37Packages.azure-mgmt-policyinsights python37Packages.azure-mgmt-powerbiembedded python37Packages.azure-mgmt-rdbms python37Packages.azure-mgmt-recoveryservices python37Packages.azure-mgmt-recoveryservicesbackup python37Packages.azure-mgmt-redis python37Packages.azure-mgmt-relay python37Packages.azure-mgmt-reservations python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-scheduler python37Packages.azure-mgmt-search python37Packages.azure-mgmt-servicebus python37Packages.azure-mgmt-servicefabric python37Packages.azure-mgmt-signalr python37Packages.azure-mgmt-sql python37Packages.azure-mgmt-storage python37Packages.azure-mgmt-subscription python37Packages.azure-mgmt-trafficmanager python37Packages.azure-mgmt-web python37Packages.azure-servicebus python37Packages.azure-servicefabric python37Packages.datashader python37Packages.google_cloud_bigquery python37Packages.jupyterlab python37Packages.jupyterlab_server python37Packages.msrest python37Packages.msrestazure python37Packages.optuna python37Packages.robotframework-tools python37Packages.starfish python37Packages.trio python37Packages.vsts python38Packages.Nikola python38Packages.azure-applicationinsights python38Packages.azure-batch python38Packages.azure-cli-core python38Packages.azure-eventgrid python38Packages.azure-graphrbac python38Packages.azure-keyvault python38Packages.azure-loganalytics python38Packages.azure-mgmt-advisor python38Packages.azure-mgmt-applicationinsights python38Packages.azure-mgmt-authorization python38Packages.azure-mgmt-batch python38Packages.azure-mgmt-batchai python38Packages.azure-mgmt-billing python38Packages.azure-mgmt-cdn python38Packages.azure-mgmt-cognitiveservices python38Packages.azure-mgmt-commerce python38Packages.azure-mgmt-common python38Packages.azure-mgmt-compute python38Packages.azure-mgmt-consumption python38Packages.azure-mgmt-containerinstance python38Packages.azure-mgmt-containerservice python38Packages.azure-mgmt-cosmosdb python38Packages.azure-mgmt-datafactory python38Packages.azure-mgmt-datalake-analytics python38Packages.azure-mgmt-datalake-store python38Packages.azure-mgmt-datamigration python38Packages.azure-mgmt-devspaces python38Packages.azure-mgmt-devtestlabs python38Packages.azure-mgmt-dns python38Packages.azure-mgmt-eventgrid python38Packages.azure-mgmt-eventhub python38Packages.azure-mgmt-hanaonazure python38Packages.azure-mgmt-iotcentral python38Packages.azure-mgmt-iothub python38Packages.azure-mgmt-iothubprovisioningservices python38Packages.azure-mgmt-keyvault python38Packages.azure-mgmt-loganalytics python38Packages.azure-mgmt-logic python38Packages.azure-mgmt-machinelearningcompute python38Packages.azure-mgmt-managementgroups python38Packages.azure-mgmt-managementpartner python38Packages.azure-mgmt-maps python38Packages.azure-mgmt-marketplaceordering python38Packages.azure-mgmt-media python38Packages.azure-mgmt-monitor python38Packages.azure-mgmt-msi python38Packages.azure-mgmt-network python38Packages.azure-mgmt-notificationhubs python38Packages.azure-mgmt-policyinsights python38Packages.azure-mgmt-powerbiembedded python38Packages.azure-mgmt-rdbms python38Packages.azure-mgmt-recoveryservices python38Packages.azure-mgmt-recoveryservicesbackup python38Packages.azure-mgmt-redis python38Packages.azure-mgmt-relay python38Packages.azure-mgmt-reservations python38Packages.azure-mgmt-resource python38Packages.azure-mgmt-scheduler python38Packages.azure-mgmt-search python38Packages.azure-mgmt-servicebus python38Packages.azure-mgmt-servicefabric python38Packages.azure-mgmt-signalr python38Packages.azure-mgmt-sql python38Packages.azure-mgmt-storage python38Packages.azure-mgmt-subscription python38Packages.azure-mgmt-trafficmanager python38Packages.azure-mgmt-web python38Packages.azure-servicebus python38Packages.azure-servicefabric python38Packages.jupyterlab python38Packages.jupyterlab_server python38Packages.modeled python38Packages.moretools python38Packages.msrest python38Packages.msrestazure python38Packages.pyls-black python38Packages.pyls-isort python38Packages.pyls-mypy python38Packages.python-language-server python38Packages.robotframework-tools python38Packages.scikit-tda python38Packages.spyder python38Packages.trio python38Packages.vsts python38Packages.zetup sage sageWithDoc

118 package were build:
adafruit-ampy fdroidserver gnome3.accerciser jira-cli jupyter paperless python27Packages.jedi python27Packages.pyls-isort python27Packages.python-language-server python37Packages.Nikola python37Packages.Pweave python37Packages.altair python37Packages.androguard python37Packages.ansible-kernel python37Packages.bash_kernel python37Packages.caffe python37Packages.chart-studio python37Packages.colorcet python37Packages.cufflinks python37Packages.dftfit python37Packages.greatfet python37Packages.holoviews python37Packages.hvplot python37Packages.intake python37Packages.ipdb python37Packages.ipdbplugin python37Packages.ipykernel python37Packages.ipyparallel python37Packages.ipython python37Packages.ipywidgets python37Packages.jedi python37Packages.jira python37Packages.jupyter python37Packages.jupyter_client python37Packages.jupyter_console python37Packages.jupyter_core python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.jupyterlab_launcher python37Packages.jupytext python37Packages.kmapper python37Packages.line_profiler python37Packages.modeled python37Packages.moretools python37Packages.nbconvert python37Packages.nbformat python37Packages.nbmerge python37Packages.nbsmoke python37Packages.nbsphinx python37Packages.nbval python37Packages.notebook python37Packages.oauthenticator python37Packages.phik python37Packages.plotly python37Packages.ptpython python37Packages.pygmo python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-dotenv python37Packages.python-language-server python37Packages.qtconsole python37Packages.runway-python python37Packages.scapy python37Packages.scikit-bio python37Packages.scikit-tda python37Packages.sopel spyder python37Packages.spyder-kernels python37Packages.vega python37Packages.widgetsnbextension python37Packages.zetup python38Packages.Pweave python38Packages.androguard python38Packages.ansible-kernel python38Packages.bash_kernel python38Packages.chart-studio python38Packages.colorcet python38Packages.greatfet python38Packages.ipdb python38Packages.ipdbplugin python38Packages.ipykernel python38Packages.ipyparallel python38Packages.ipython python38Packages.ipywidgets python38Packages.jedi python38Packages.jira python38Packages.jupyter python38Packages.jupyter_client python38Packages.jupyter_console python38Packages.jupyter_core python38Packages.jupyterhub python38Packages.jupyterhub-ldapauthenticator python38Packages.jupyterlab_launcher python38Packages.jupytext python38Packages.kmapper python38Packages.line_profiler python38Packages.nbconvert python38Packages.nbformat python38Packages.nbmerge python38Packages.nbsmoke python38Packages.nbsphinx python38Packages.nbval python38Packages.notebook python38Packages.oauthenticator python38Packages.plotly python38Packages.ptpython python38Packages.pygmo python38Packages.python-dotenv python38Packages.qtconsole python38Packages.runway-python python38Packages.scapy python38Packages.sopel python38Packages.spyder-kernels python38Packages.widgetsnbextension theharvester thonny vimPlugins.jedi-vim

@Mic92
Copy link
Member

Mic92 commented Oct 28, 2019

Jedi was merged independently of this. So we can merge this one as well to fix python language server.

@Mic92 Mic92 merged commit 33cb215 into NixOS:master Oct 28, 2019
@matthuszagh matthuszagh deleted the python-language-server branch October 28, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthuszagh @Mic92 @jonringer