iosevka: 2.3.0 -> 2.3.2 #72049
Merged
iosevka: 2.3.0 -> 2.3.2 #72049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit include: - update iosevka version - fix extraParameters, was not able to inject all needed settings - format file - update package.json
c0bw3b
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
Result of nix-review pr 72049 1
5 package are marked as broken and were skipped:
- casperjs
- facette
- meguca
- sage
- sageWithDoc
1 package failed to build:
- image_optim
26 package were build:
- antora
- create-cycle-app
- emojione
- fast-cli
- gtop
- hueadm
- iosevka
- joplin
- lessc
- lumo
- parity-ui
- python37Packages.jupyterhub
- python37Packages.jupyterhub-ldapauthenticator
- python37Packages.oauthenticator
- python38Packages.jupyterhub
- python38Packages.jupyterhub-ldapauthenticator
- python38Packages.oauthenticator
- rambox-pro
- shout
- slack
- slack-dark
- sloc
- styx
- thelounge
- twemoji-color-font
- wasm-text-gen
The image_optim failure is unrelated to this, just a proxy blocking access to pngout source archive during my review.
|
@GrahamcOfBorg build iosevka pngout |
|
On another machine: Result of 2 package were build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit include:
Motivation for this change
There was a new version of iosevka + extraParameters wasn't working as expected. For example, if I wanted to add one entry of "iosevka.compLig", I would have to use an empty set.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @cstrahan @jfrankenau @ttuegel @rileyinman