Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kresd: Support setting the amount of threads #72014

Closed
wants to merge 1 commit into from
Closed

nixos/kresd: Support setting the amount of threads #72014

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Oct 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vcunat

vcunat
vcunat requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no... I remember now, it will refuse this style.

[system] when run under systemd-style supervision, use single-process only

We'll need to go the way of templated systemd services, as packaged in other officially supported distros. Well, temporarily we might patch this check, as it's not useful anymore IIRC, but that's probably not worth it.

@Lassulus
Copy link
Member

so whats up here?

@vcunat
Copy link
Member

vcunat commented Nov 20, 2019 •
edited

I have this in my queue, but so far it hasn't made it to the top. EDIT: note that it's not at all easy to saturate one CPU with work, as it can handle typically N0 000 QPS.

@vcunat vcunat mentioned this pull request Jan 27, 2020
Merged
11 tasks
@vcunat
Copy link
Member

vcunat commented Jan 27, 2020

Replaced by PR #78628.

@vcunat vcunat closed this Jan 27, 2020
vcunat added a commit that referenced this pull request Feb 5, 2020
@vcunat
Merge #78628: knot-resolver: 4.3.0 -> 5.0.1
baeed03 
The service needed lots of changes. A few smaller changes
are added into the PR, e.g. replacement for PR #72014.
See the commit messages for details.
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 5, 2020
@vcunat @dtzWill
Merge NixOS#78628: knot-resolver: 4.3.0 -> 5.0.1
9abd8d4 
The service needed lots of changes. A few smaller changes
are added into the PR, e.g. replacement for PR NixOS#72014.
See the commit messages for details.

(cherry picked from commit baeed03)
@dasJ dasJ deleted the kresd-threads branch October 15, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @Lassulus @vcunat