Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin conkeror to firefox esr-5.2 #72090

Merged
merged 1 commit into from Feb 9, 2020
Merged

pin conkeror to firefox esr-5.2 #72090

merged 1 commit into from Feb 9, 2020

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented Oct 27, 2019

Pin conkeror dependencies to firefox esr-5.2 since it won't work on newer esrs.
Fixes #48285

Things done
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from astsmtl October 27, 2019 14:57
DinCahill
DinCahill approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@DinCahill DinCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Binary tested working. :shipit:

@veprbl
Copy link
Member

veprbl commented Feb 9, 2020

@GrahamcOfBorg eval

@veprbl veprbl merged commit eee784a into NixOS:master Feb 9, 2020
@flokli
Copy link
Contributor

flokli commented Feb 9, 2020

firefox-esr-52 is about to be removed, and conkeror is also asking users to move to alternatives, as explained in #48285 (comment), see http://conkeror.org/Alternatives.

I added the removal to #79115.

veprbl pushed a commit that referenced this pull request Feb 17, 2020
@PanAeon @veprbl
conkeror: pin to firefox-esr-52 (#72090)
4f4b9da 
(cherry picked from commit eee784a)
cc #72090
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinCahill DinCahill DinCahill approved these changes

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conkeror doesn't work
4 participants
@PanAeon @veprbl @flokli @DinCahill