nixos/ceph: Rename old ceph test and add new multi-node test #72094
Conversation
Rename the old ceph test to ceph-single-node and add a new test ceph-multi-node. The ceph-single-node represents a dev cluster whereas ceph-multi-node is closer to a prod cluster.
…e sharing of the admin keyring to the shared directory instead of netcat
|
@lejonet this looks really nice, thanks :-) Can you add/rename in |
|
Thanks! Can we add some bluestore OSDs in the test too? |
|
I'm happy to merge this as is. Bluestore should probably be supported in
the module directly and then added to the tests rather than increasing the
scope of this pr. Unless you feel differently @lejonet? :)
…On Fri, Nov 1, 2019, 15:42 Florian Klink ***@***.***> wrote:
Thanks! Can we add some bluestore OSDs in the test too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72094?email_source=notifications&email_token=AABVRYVDH3NOHVTPSVMPNJLQRQ565A5CNFSM4JFR2ITKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3DWNQ#issuecomment-548813622>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVRYWE3KYSIKQS6PVMERTQRQ565ANCNFSM4JFR2ITA>
.
|
As @srhb points out, bluestore OSDs isn't supported by the module yet, therefor there isn't any point to add a test with them, yet. The reason is that we need to figure out a way to handle the activation needed for bluestore OSDs (which we don't need with filestore due to them being regular mounts) in the module first. |
I'm just going to refactor the single-node test with the new "framework" and commit that, then I'm fine with merging the PR. |
|
@srhb |
|
Thanks @lejonet |
Rename the old ceph test to ceph-single-node and add a new test
ceph-multi-node. The ceph-single-node represents a dev cluster whereas
ceph-multi-node is closer to a prod cluster.
Motivation for this change
I created a test that better emulates an actual cluster, with different nodes for different daemons and renamed the old test to "single-node". The single-node test more reflects how a dev cluster would be setup, with everything on one machine and to get better coverage for changes to the ceph package, the multi node tests separates mon from osd daemons completely.
A bunch of python packages seems to be broken in master, so I couldn't test with nix-review WIP (I had to change version of python-modules/cheroot from 6.5.8 (master) to 6.5.6 (19.09) to get the test to run at all).
I thought we could maybe use this pull request to get a few more tests for ceph, not just the multi-node one. For example, doing a single-node test that uses ceph-volume to provision the OSD daemons might be warranted.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @srhb @johanot @lejonet