python3Packages.pytest4: deterministic bytecode #72091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons that are not clear to me, the pytest4 check phase produces a lot of non-deterministic bytecode files. This PR turns off bytecode generation and disables a test that force enables bytecode generation.
|
@FRidh opinions? |
FRidh
approved these changes
Apr 22, 2020
| rm testing/test_argcomplete.py | ||
|
|
||
| # determinism - this test writes non deterministic bytecode | ||
| rm -rf testing/test_assertrewrite.py |
There was a problem hiding this comment.
That's I think because it uses _write_pyc_fp() which is pytest's own internal testing function for writing bytecode.
| # determinism - this test writes non deterministic bytecode | ||
| rm -rf testing/test_assertrewrite.py | ||
|
|
||
| PYTHONDONTWRITEBYTECODE=1 $out/bin/py.test -x testing/ -k "not test_collect_pyargs_with_testpaths" |
There was a problem hiding this comment.
A lot of files have indeed been rewritten with this bad bytecode.
There was a problem hiding this comment.
should we add PYTHONDONTWRITEBYTECODE=1 to the pytestCheckHook @FRidh ?
There was a problem hiding this comment.
Maybe. It can happen in case pytest is simply used. A better solution is probably for it to adhere to SOURCE_DATE_EPOCH, but there's probably a reason why this custom function exists.
|
@GrahamcOfBorg build python3Packages.pytest4 |
|
@GrahamcOfBorg build python3Packages.pytest_4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
For reasons that are not clear to me, the pytest4 check phase produces a lot of non-deterministic bytecode files. This PR turns off bytecode generation during test execution and additionally disables a test that force enables bytecode generation.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @domenkozar @lovek323 @madjar @lsix