Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using hardeningDisable = [ "fortify" ]; for Go packages #72093

Merged
merged 1 commit into from Oct 28, 2019
Merged

stop using hardeningDisable = [ "fortify" ]; for Go packages #72093

merged 1 commit into from Oct 28, 2019

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 27, 2019 •
edited

Motivation for this change

it seems that the issue #25959 is not present anymore. Let's get rid of the workarounds.

The following got built just fine:

$ nix-shell -I nixpkgs=. -p go-ethereum containerd docker podman livepeer trezord flannel
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

go-ethereum: @adisbladis @asymmetric @lionello @xrelkd
containerd: @offline @vdemeester
docker: @NeQuissimus @offline @tailhook @vdemeester @periklis
podman: @vdemeester @saschagrunert
livepeer: @elitak
flannel: @johanot @offline

@prusnak
stop using hardeningDisable = [ "fortify" ]; for Go packages
afd38ea 
it seems that the issue NixOS#25959 is not present anymore
@prusnak prusnak mentioned this pull request Oct 27, 2019
Closed
@NeQuissimus
Copy link
Member

@GrahamcOfBorg test docker

saschagrunert
saschagrunert approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester
Copy link
Member

LGTM 👍🏼

@adisbladis adisbladis merged commit 5dd330e into NixOS:master Oct 28, 2019
@adisbladis
Copy link
Member

Only one package fails in nox-review (python3Packages.jupyter-repo2docker). This one is already broken on master.
cc maintainer @costrouc

@prusnak prusnak deleted the go-fortify branch October 28, 2019 16:11
@zowoq zowoq mentioned this pull request Apr 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prusnak @NeQuissimus @vdemeester @adisbladis @saschagrunert