Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.docker: fix build on darwin #72002

Merged
merged 1 commit into from Oct 26, 2019
Merged

pythonPackages.docker: fix build on darwin #72002

merged 1 commit into from Oct 26, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 26, 2019

Motivation for this change

Fixes #71993
cc: @jbmusso

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.docker python3Packages.docker python38Packages.docker

@domenkozar domenkozar merged commit e478127 into NixOS:master Oct 26, 2019
@marsam marsam deleted the fix-pythonPackages.docker-darwin branch October 26, 2019 09:36
@marsam marsam mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: documentation 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arion package build failure on Mac Os X ("OSError: AF_UNIX path too long" error when building docker)
3 participants
@marsam @jonringer @domenkozar