Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluez: 5.50 -> 5.52 #74995

Merged
merged 2 commits into from Dec 9, 2019
Merged

bluez: 5.50 -> 5.52 #74995

merged 2 commits into from Dec 9, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Dec 4, 2019 •
edited

Motivation for this change

Replaces PR #69460

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify previous commenters

cc @bkchr @mweinelt @jonringer @jtojnar @adisbladis

@Moredread
Copy link
Contributor Author

@mweinelt I disabled doCheck again, I saw the midi and another test fail on a Windows WSL install, each in seperate runs. On my NixOS machine though all run fine. I think we should investigate this issue separately.

@Moredread Moredread changed the base branch from master to staging December 4, 2019 17:45
@Moredread Moredread changed the base branch from staging to master December 4, 2019 17:46
@Moredread
Copy link
Contributor Author

@GrahamcOfBorg build bluez

@mweinelt
Copy link
Member

mweinelt commented Dec 4, 2019

Tested with Logitech MX Ergo and Sony WH-1000XM3 and working great. Thanks alot for taking care of this!

jtojnar
jtojnar requested changes Dec 4, 2019
View reviewed changes
pkgs/os-specific/linux/bluez/default.nix Show resolved Hide resolved
pkgs/os-specific/linux/bluez/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/bluez/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/bluez/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@FRidh FRidh added this to Needs review in Staging Dec 5, 2019
bkchr and others added 2 commits December 8, 2019 20:47
@bkchr @Moredread
bluez: 5.50 -> 5.51
19f4262 
Also add new configuration flag options and enable them for the bluezFull package by default.
@Moredread
bluez: 5.51 -> 5.52, aliased bluezFull to bluez
83655d6
@Moredread
Copy link
Contributor Author

@GrahamcOfBorg build bluez

Staging automation moved this from Needs review to Ready Dec 9, 2019
worldofpeace
worldofpeace approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace worldofpeace merged commit a83fa64 into NixOS:staging Dec 9, 2019
Staging automation moved this from Ready to Done Dec 9, 2019
@worldofpeace worldofpeace mentioned this pull request Dec 9, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

I've built #75317, with checks on NixOS three times in succession without any test failure.

@jtojnar jtojnar mentioned this pull request Dec 14, 2019
Merged
@Moredread Moredread deleted the bluez branch May 5, 2020 12:49
timokau added a commit to timokau/dotfiles that referenced this pull request Sep 27, 2022
@timokau
Do not use bluezFull alias
c03b0e0 
bluezFull has been aliased to bluez for a while now. See

- NixOS/nixpkgs#69460 (comment)
- NixOS/nixpkgs#74995
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-channel-23-11-bluez-and-bluezfull/37285/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Moredread @mweinelt @worldofpeace @nixos-discourse @jtojnar @bkchr