Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctl: 1.31.2 -> 1.35.0 #75000

Merged
merged 1 commit into from Dec 4, 2019
Merged

doctl: 1.31.2 -> 1.35.0 #75000

merged 1 commit into from Dec 4, 2019

Conversation

noteed
Copy link

@noteed noteed commented Dec 4, 2019 •
edited

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
    No idea what it is supposed to do. I got a binary built but with some errors displayed first.
$ nix-shell -p nix-review --run "nix-review pr 75000"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/75000/head:refs/nix-review/1
remote: Enumerating objects: 24, done.
remote: Counting objects: 100% (24/24), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 31 (delta 18), reused 16 (delta 16), pack-reused 7
Unpacking objects: 100% (31/31), done.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master               -> refs/nix-review/0
 * [new ref]                 refs/pull/75000/head -> refs/nix-review/1
$ git worktree add ./.review/pr-75000 ff954e075994e351dbe277e4c3eed6dba831774a
Preparing worktree (detached HEAD ff954e07599)
Checking out files: 100% (20407/20407), done.
HEAD is now at ff954e07599 Merge pull request #74321 from romildo/upd.connman-notify
error: while querying the derivation named 'nix-2.4pre20191022_9cac895':
while evaluating the attribute 'src' of the derivation 'nix-2.4pre20191022_9cac895' at /home/thu/projects/nixpkgs/.review/pr-75000/pkgs/tools/package-management/nix/default.nix:28:14:
unknown hash algorithm '', at /home/thu/projects/nixpkgs/.review/pr-75000/pkgs/build-support/fetchurl/default.nix:119:3
$ git merge --no-commit e63832ae21dfea7b98b94b0d8a97c2ce381fe3d1
Automatic merge went well; stopped before committing as requested
error: while querying the derivation named 'nix-2.4pre20191022_9cac895':
while evaluating the attribute 'src' of the derivation 'nix-2.4pre20191022_9cac895' at /home/thu/projects/nixpkgs/.review/pr-75000/pkgs/tools/package-management/nix/default.nix:28:14:
unknown hash algorithm '', at /home/thu/projects/nixpkgs/.review/pr-75000/pkgs/build-support/fetchurl/default.nix:119:3
Building in /run/user/1000/nix-review-_gpd20oc
$ nix-shell --no-out-link --keep-going --max-jobs 8 --option build-use-sandbox true --run true -p doctl
https://github.com/NixOS/nixpkgs/pull/75000
$ nix-shell -p doctl

[nix-shell:~/projects/nixpkgs]$ which doctl
/nix/store/yiy87164yk73aknnfii37w33lg521sbz-doctl-1.35.0-bin/bin/doctl

[nix-shell:~/projects/nixpkgs]$ exit
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    Previously:
$ nix path-info -S /nix/store/g4akkf9qg59dal7l0qd8yxfn07xqcbsb-doctl-1.31.2-bin/bin/doctl
/nix/store/g4akkf9qg59dal7l0qd8yxfn07xqcbsb-doctl-1.31.2-bin       48976424

After

nix path-info -S /nix/store/wszxllpx9bai6gd7d0nc2nk4w0wjrvs0-doctl-1.35.0-bin/bin/doctl
/nix/store/yiy87164yk73aknnfii37w33lg521sbz-doctl-1.35.0-bin       78187088
Notify maintainers

cc @langston-barrett

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build doctl

thoughtpolice
thoughtpolice approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darwin seems to be good. Thanks!

@thoughtpolice thoughtpolice merged commit bce9e72 into NixOS:master Dec 4, 2019
@noteed noteed deleted the nixpkgs/doctl-update branch December 4, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@langston-barrett langston-barrett langston-barrett approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@noteed @thoughtpolice @langston-barrett @Janik-Haag