New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starship: 0.26.5 -> 0.27.0 #74923
starship: 0.26.5 -> 0.27.0 #74923
Conversation
I'm seeing the same test failure as ofborg locally. |
@davidtwco I added a patch to fix absolute paths in tests. Should be fine now. |
I have a dumb question, I'm still new to all of this. There's no other way than patching the tests? It's not possible to make the tests run with coreutils in PATH? To avoid a patch that could break on any release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still approving. It builds and runs fine. 👍
dc5a555
to
0690586
Compare
@Ma27 the last commit should have been amended |
starship: 0.26.5 -> 0.27.0 (cherry picked from commit 7af0097)
Motivation for this change
https://github.com/starship/starship/releases/tag/v0.27.0
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @bbigras @davidtwco
This change is