Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 0.26.5 -> 0.27.0 #74923

Merged
merged 3 commits into from Dec 4, 2019
Merged

starship: 0.26.5 -> 0.27.0 #74923

merged 3 commits into from Dec 4, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 3, 2019

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.27.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bbigras @davidtwco


This change is Reviewable

@davidtwco
Copy link
Member

I'm seeing the same test failure as ofborg locally.

@Br1ght0ne
Copy link
Member Author

@davidtwco I added a patch to fix absolute paths in tests. Should be fine now.
@GrahamcOfBorg build starship

@bbigras
Copy link
Contributor

bbigras commented Dec 3, 2019

I have a dumb question, I'm still new to all of this. There's no other way than patching the tests? It's not possible to make the tests run with coreutils in PATH? To avoid a patch that could break on any release.

Copy link
Contributor

@bbigras bbigras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still approving. It builds and runs fine. 👍

pkgs/tools/misc/starship/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/starship/default.nix Outdated Show resolved Hide resolved
@Ma27 Ma27 merged commit 7af0097 into NixOS:master Dec 4, 2019
@jonringer
Copy link
Contributor

@Ma27 the last commit should have been amended

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 4, 2019
starship: 0.26.5 -> 0.27.0
(cherry picked from commit 7af0097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants