Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive.bin: fix darwin build #74994

Merged
merged 1 commit into from Dec 4, 2019
Merged

texlive.bin: fix darwin build #74994

merged 1 commit into from Dec 4, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 4, 2019 •
edited

Motivation for this change

example failure https://hydra.nixos.org/build/107771996

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 4, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.pplpy

@ofborg ofborg bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Dec 4, 2019
@jtojnar jtojnar merged commit fe6953e into NixOS:master Dec 4, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Dec 4, 2019

Thanks. I wonder why do we support C++14 on Linux by default.

@jonringer jonringer deleted the fix-texlive-bin branch December 4, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @jtojnar @marsam