Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1601026] Mark some marker tests as tentative. #20599

Merged
merged 1 commit into from Dec 4, 2019
Merged

[Gecko Bug 1601026] Mark some marker tests as tentative. #20599

merged 1 commit into from Dec 4, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

They use properties like writing-mode or display inside ::marker, which is not
currently allowed by css-pseudo.

Differential Revision: https://phabricator.services.mozilla.com/D55718

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1601026
gecko-commit: d0f38d2fd9834cd175dc90e1ae8478ed30485cb8
gecko-integration-branch: autoland
gecko-reviewers: Oriol

@emilio @moz-wptsync-bot
Mark some marker tests as tentative.
3f5dd65 
They use properties like writing-mode or display inside ::marker, which is not
currently allowed by css-pseudo.

Differential Revision: https://phabricator.services.mozilla.com/D55718

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1601026
gecko-commit: d0f38d2fd9834cd175dc90e1ae8478ed30485cb8
gecko-integration-branch: autoland
gecko-reviewers: Oriol
wpt-pr-bot
wpt-pr-bot approved these changes Dec 3, 2019
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@emilio
Copy link
Contributor

emilio commented Dec 3, 2019 

+ git init
Initialized empty Git repository in /home/test/web-platform-tests/.git/
+ git remote add origin https://github.com/web-platform-tests/wpt.git
+ retry git fetch --quiet --depth=50 --tags origin refs/pull/20599/merge:task_head
Running git fetch --quiet --depth=50 --tags origin refs/pull/20599/merge:task_head [try 1/5]
fatal: git fetch-pack: expected shallow list
fatal: The remote end hung up unexpectedly
Command failed, waiting 3 seconds to retry
Running git fetch --quiet --depth=50 --tags origin refs/pull/20599/merge:task_head [try 2/5]
Command succeeded
+ git checkout --quiet task_head
git rev-parse task_head
CRITICAL: task_head points at 01415a5e90e52fba6c136f5e838dffcaed61c1db, expected 21a01ffa3dbd83f0f0d9ae97abe41c0642e97dcf. This may be because the branch was updated
[taskcluster 2019-12-03 23:10:53.214Z] === Task Finished ===

@jgraham halp! :)

@emilio
Copy link
Contributor

emilio commented Dec 4, 2019

I'll try to do it myself, let's see...

@emilio emilio closed this Dec 4, 2019
@emilio emilio reopened this Dec 4, 2019
@jgraham
Copy link
Contributor

jgraham commented Dec 4, 2019

@emilio Thanks for handling that. I made #20557 to deal with this problem, but it's still waiting on review.

@moz-wptsync-bot moz-wptsync-bot merged commit ce29abf into master Dec 4, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1601026 branch December 4, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
css-pseudo mozilla:gecko-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moz-wptsync-bot @emilio @jgraham @wpt-pr-bot