Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.mutter: backport patches from gnome-3-34 branch #75002

Merged
merged 2 commits into from Dec 7, 2019
Merged

gnome3.mutter: backport patches from gnome-3-34 branch #75002

merged 2 commits into from Dec 7, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I did the most sane thing IMHO, which is to use a generated patch from GitHub.
Mostly to avoid our silly versioning for non-released commits.

Things done

Haven't been running with this commit, but have been using the same git rev from GitLab from my overlay.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace mentioned this pull request Dec 4, 2019
Closed
@worldofpeace
Copy link
Contributor Author

While I was here I got to submitting the patches so sysprof in mutter works

@worldofpeace worldofpeace added this to In Progress in GNOME Dec 4, 2019
hedning
hedning approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace
Copy link
Contributor Author

Let's go 🕊️

@worldofpeace worldofpeace merged commit 942567a into NixOS:master Dec 7, 2019
GNOME automation moved this from In Progress to Done Dec 7, 2019
@worldofpeace worldofpeace deleted the mutter-gnome-3-34-branch branch December 7, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @hedning @jtojnar