Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racket: 7.4 -> 7.5 #74968

Merged
merged 1 commit into from Dec 5, 2019
Merged

racket: 7.4 -> 7.5 #74968

merged 1 commit into from Dec 5, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 4, 2019

Motivation for this change

Release Announcement: https://download.racket-lang.org/v7.5.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

davidak
davidak approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • all depending packages build
Possible improvements
Comments

Thanks for your contribution! ✨

I have tested this binaries:

racket: racket, drracket
racket-minimal: racket, raco

cc maintainers @henrytill @vrthra

davidak
davidak requested changes Dec 4, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your release link:

Almost all of Racket version 7.5 is distributed under a new,
less-restrictive license: either the Apache 2.0 license or the MIT
license. See https://blog.racket-lang.org/2019/11/completing-racket-s-relicensing-effort.html
for more details.

Please change the license to MIT and Apache2!

Br1ght0ne
Br1ght0ne approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @davidak said, besides that - LGTM.

@marsam
Copy link
Contributor Author

marsam commented Dec 5, 2019

@davidak good catch, I've updated the licence field. Thanks!

@marsam marsam merged commit f00e169 into NixOS:master Dec 5, 2019
@marsam marsam deleted the update-racket branch December 5, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak requested changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @davidak @Br1ght0ne