buildImageWithNixDb: export USER #74959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to Nix user detection (./src/nix-channel/nix-channel.cc#L-166) cause this function to error. Exporting USER fixes this.
|
@GrahamcOfBorg test docker-tools |
nlewo
approved these changes
Dec 4, 2019
nlewo
requested changes
Dec 5, 2019
| @@ -845,6 +845,7 @@ rec { | |||
| echo " be better to only have one layer that contains a nix store." | |||
|
|
|||
| export NIX_REMOTE=local?root=$PWD | |||
| export USER=root | |||
There was a problem hiding this comment.
Actually, I think it would be better to use "nobody" and add a comment to explain why it is required:/
|
I'm fixing the test in #75038. |
nlewo
reviewed
Dec 6, 2019
Co-Authored-By: lewo <lewo@abesis.fr>
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 19, 2020
dockerTools.buildImageWithNixDb: export USER Changes to Nix user detection (./src/nix-channel/nix-channel.cc#L-166) cause this function to error. Exporting USER fixes this. (cherry picked from commit 81b0a20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Nix user detection (./src/nix-channel/nix-channel.cc#L-166)
cause this function to error. Exporting USER fixes this.
Motivation for this change
Failure to use the buildImageWithNixDb with recent Nixpkgs.
Things done
Env var USER is needed to satisfy check in Nix to discover username.
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @