Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust infinite-scroll-event to pass. #20600

Merged
merged 1 commit into from Dec 4, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 4, 2019

scrollTopMax is not a standardized web feature. The actual
functionality was passing as of:

https://chromium.googlesource.com/chromium/src/+/6a9dd6d26726f346345cf1970c2bc3af3ec1afbd

Bug: 997502
Change-Id: Ic120d09d0e6a9652c195afe0ac7cacece917dd47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949556
Reviewed-by: Nick Burris <nburris@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721318}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

scrollTopMax is not a standardized web feature. The actual
functionality was passing as of:

https://chromium.googlesource.com/chromium/src/+/6a9dd6d26726f346345cf1970c2bc3af3ec1afbd

Bug: 997502
Change-Id: Ic120d09d0e6a9652c195afe0ac7cacece917dd47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949556
Reviewed-by: Nick Burris <nburris@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721318}
@emilio
Copy link
Contributor

emilio commented Dec 4, 2019

Ew, this one is my fault, thanks for fixing this @chrishtr :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants