Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export background color as paper color #525

Closed
1 task
ghost opened this issue Dec 4, 2019 · 1 comment
Closed
1 task

Export background color as paper color #525

ghost opened this issue Dec 4, 2019 · 1 comment
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Dec 4, 2019 •
edited by ghost

System information

  • SolveSpace version: 3.0~690f87c
  • Operating system: Debian 9.x stretch (x86_64)

Expected behavior

Add option in «Property Browser > configuration > export background color» for 2D view export to PDF, SVG, etc.

  • export background color

Additionally, if this option would be disabled exported PNG image (via «Export Image» or if render it via solvespace-cli) background should be transparent.

For solvespace-cli add options --bg-color on / --bg-color off.

Actual behavior

If export to PDF or SVG paper color always is white (transparent).

Actually only «Export Image» or render to PNG using solvespace-cli always use background color.

Additional information

For bugs, please attach a savefile that shows the problematic behavior.
You can attach .slvs files by archiving them into a .zip first.
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Mar 25, 2020
@nabijaczleweli
Export background colour in SVG, if enabled
63e1c33 
Ref: solvespace#525
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Mar 25, 2020
@nabijaczleweli
Export backgrounds in vector files via VectorFW::Rectangle()
14c5d1d 
Ref: solvespace#525
@nabijaczleweli nabijaczleweli mentioned this issue Mar 25, 2020
Merged
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Mar 26, 2020
@nabijaczleweli
Export backgrounds in vector files
9e073b0 
VectorFileWriter::Background() is an empty impl, except that it writes
  * a rectangle the size of the output for EPS and PDF, and
  * a <style> element setting background-color for SVG

Ref: solvespace#525
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue May 4, 2020
@nabijaczleweli
Export backgrounds in vector files
d4b0a64 
VectorFileWriter::Background() is an empty impl, except that it writes
  * a rectangle the size of the output for EPS and PDF, and
  * a <style> element setting background-color for SVG

Ref: solvespace#525
nabijaczleweli added a commit to nabijaczleweli/solvespace that referenced this issue Jun 27, 2020
@nabijaczleweli
Export backgrounds in vector files
5fc14c1 
VectorFileWriter::Background() is an empty impl, except that it writes
  * a rectangle the size of the output for EPS and PDF, and
  * a <style> element setting background-color for SVG

Ref: solvespace#525
phkahler pushed a commit that referenced this issue Sep 6, 2020
@nabijaczleweli @phkahler
Export backgrounds in vector files
360b347 
VectorFileWriter::Background() is an empty impl, except that it writes
  * a rectangle the size of the output for EPS and PDF, and
  * a <style> element setting background-color for SVG

Ref: #525
@phkahler
Copy link
Member

phkahler commented Sep 6, 2020

Does #568 mean we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @phkahler