hdl.ast: Fix width for unary minus operator on signed argument. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly represent a negation of a signed X-bit quantity we may, in general, need a signed (X+1)-bit signal — for example, negation of 3-bit -4 is 4, which is not representable in signed 3 bits.
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 82.19% 82.16% -0.04%
==========================================
Files 34 34
Lines 5645 5645
Branches 1161 1160 -1
==========================================
- Hits 4640 4638 -2
- Misses 860 862 +2
Partials 145 145
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly represent a negation of a signed X-bit quantity we may, in
general, need a signed (X+1)-bit signal — for example, negation of
3-bit -4 is 4, which is not representable in signed 3 bits.