Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrooge: 2.20.0 -> 2.21.0 #75050

Merged
merged 1 commit into from Dec 14, 2019
Merged

skrooge: 2.20.0 -> 2.21.0 #75050

merged 1 commit into from Dec 14, 2019

Conversation

alapshin
Copy link
Contributor

@alapshin alapshin commented Dec 5, 2019

Motivation for this change

Update to new upstream version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alapshin
skrooge: 2.20.0 -> 2.21.0
0b05c61 
Update to new upstream version
@ofborg ofborg bot requested a review from jokogr December 5, 2019 16:13
@tomberek
Copy link
Contributor

tomberek commented Dec 8, 2019

Builds and runs. Seems to function. I did not evaluate the impact of removing the patch.

jokogr
jokogr approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@jokogr jokogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@tomberek thanks for checking it!

@jokogr jokogr merged commit 295d8ba into NixOS:master Dec 14, 2019
@alapshin alapshin deleted the feature/skroge-2.21.0 branch April 9, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@jokogr jokogr jokogr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alapshin @tomberek @jokogr