Advertise DocumentPolicy & Network Err when receive incompatible policy #20618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 4, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1947187
branch
6 times, most recently
from
9e1427c
to
d3a2603
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1947187
branch
7 times, most recently
from
a4a3b04
to
89b28fa
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1947187
branch
2 times, most recently
from
0dff214
to
ae08dac
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1947187
branch
7 times, most recently
from
fca4727
to
489e238
Compare
- Advertise required document policy on out-going requests. - Parse and initialize document policy in security context. - Replace with page with empty document when incoming document policy is incompatible with required policy. - A boolean flag body_loader_finished is added to SimRequestBase::Finish because when testing page blocked by document policy situation in document_loader_test.cc, body_loader.Finish will be called twice, once in WebNavigationParams::FillStaticResponse, once in test framework, which will crash the test because of a DCHECK. Bug: 993790 Change-Id: I823675408a0d52e8048172ae23d409a5f14e8eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947187 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#730275}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1947187
branch
from
489e238
to
adca3e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is incompatible with required policy.
because when testing page blocked by document policy situation in
document_loader_test.cc, body_loader.Finish will be called twice, once
in WebNavigationParams::FillStaticResponse, once in test framework, which
will crash the test because of a DCHECK.
Bug: 993790
Change-Id: I823675408a0d52e8048172ae23d409a5f14e8eb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947187
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#730275}