Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: v.2.3.1 -> v2.3.2 #74960

Merged
merged 1 commit into from Dec 4, 2019
Merged

nix-prefetch-github: v.2.3.1 -> v2.3.2 #74960

merged 1 commit into from Dec 4, 2019

Conversation

mtetreault
Copy link

Motivation for this change

Fix the issue where nix-prefetch-github return the wrong rev value when using tag
seppeljordan/nix-prefetch-github#21

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS 19.09
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @seppeljordan

@ofborg ofborg bot requested a review from seppeljordan December 4, 2019 02:10
seppeljordan
seppeljordan approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@seppeljordan seppeljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I double checked the the sha256 and it is correct.

davidak
davidak approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • update fixes the reported problem
Possible improvements
Comments

Thanks for your contribution! ✨

@Ma27 Ma27 merged commit b05a453 into NixOS:release-19.09 Dec 4, 2019
@mtetreault
Copy link
Author

Should I create a seperate PR to bring this to master?

@Ma27
Copy link
Member

Ma27 commented Dec 5, 2019

AFAICS we already have v2.3.2 on master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@seppeljordan seppeljordan seppeljordan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtetreault @Ma27 @davidak @seppeljordan