New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exult: 1.4.9rc1 -> 1.5.0git #74962
exult: 1.4.9rc1 -> 1.5.0git #74962
Conversation
}; | ||
|
||
configureFlags = [ "--disable-tools" ]; | ||
preConfigure = "./autogen.sh"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add autoreconfHook
(instead of automake
and autoconf
and libtool
) to nativeBuildInputs
.
@@ -12,35 +12,30 @@ let | |||
in | |||
|
|||
stdenv.mkDerivation rec { | |||
name = "exult-1.4.9rc1"; | |||
name = "exult-1.5.0git"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to pname
and version
.
src = fetchFromGitHub { | ||
owner = "exult"; | ||
repo = "exult"; | ||
rev = "b727abfffc08a54e528bc1194d0de8562d18d74e"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's up with their releases names: https://github.com/exult/exult/releases ?
It seems to me they use the releases names to imply what major changes were done in that release. Hence, I'd switch to a date based version =
and download whatever they count as a release.
[ # Arch Linux patch set. | ||
./arch.patch | ||
]; | ||
configureFlags = [ "--disable-tools" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an interesting feature. Could you perhaps add a enableTools
to the derivation's arguments and use lib.optionals
here?
I think this has been superseded by #89364 now, it can be closed. |
Motivation for this change
The previous version, 1.4.9rc1 would not run for me after a fresh install. Since the tarball for that was the latest version available on SourceForge, I switched to using the GitHub sources at the current latest commit. This removes the need for the arch patches too.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @edolstra