Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: 0.2.55 -> 0.2.56 #74963

Merged
merged 1 commit into from Dec 4, 2019
Merged

ffsend: 0.2.55 -> 0.2.56 #74963

merged 1 commit into from Dec 4, 2019

Conversation

equirosa
Copy link
Contributor

@equirosa equirosa commented Dec 4, 2019

Motivation for this change

There has been a new release of ffsend, which fixes a couple bugs.
https://github.com/timvisee/ffsend/releases/tag/v0.2.56

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from lilyball December 4, 2019 02:30
lilyball
lilyball approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@lilyball lilyball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS (with sandbox)

@marsam marsam merged commit c54a5fa into NixOS:master Dec 4, 2019
@marsam
Copy link
Contributor

marsam commented Dec 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyball lilyball lilyball approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@equirosa @marsam @lilyball