qtspim: init at 722 #74999

aske · 2019-12-04T20:37:09Z

Motivation for this change

Add a MIPS32 simulator.

To build a documentation I've needed to set QT_QPA_PLATFORM_PATH and QT_PLUGIN_PATH because qhelpgenerator failed with:

qt.qpa.plugin: Could not find the Qt platform plugin "minimal" in ""

Either way after installation I did not manage to make qtspim find its help file, so I added a patch disabling doc building to save some build time.

@ttuegel maybe you have ideas on what's going on?

Things done

Notify maintainers

cc @

langston-barrett · 2019-12-04T21:42:40Z

pkgs/applications/virtualization/spim/default.nix

+
+  buildInputs = [ qtbase qttools ];
+
+  # Remove build artefacts from the repo


Suggested change

# Remove build artefacts from the repo

# Remove build artifacts from the repo

Fixed, thanks!

ttuegel · 2019-12-08T00:45:21Z

pkgs/applications/virtualization/spim/default.nix

+    install -D ../Documentation/qtspim.man $out/usr/share/man/man1/qtspim.1
+    gzip -f --best $out/usr/share/man/man1/qtspim.1
+
+    install -d $out/usr/share/qtspim


All of these paths should be $out/share/... (no /usr prefix). This may affect finding the files at runtime.

Thanks, fixed!

Finally found what's up with the docs -- doesn't have anything to do with Qt, just a bunch of hardcoded paths in the source code (missed initially them while stracing as qtspim accessed them, while I expected other syscalls).

aske · 2019-12-08T16:13:44Z

pkgs/applications/virtualization/spim/default.nix

+  buildPhase = ''
+    export QT_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}"
+    export QT_QPA_PLATFORM_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}/platforms"
+    make


@ttuegel is there a better way to make qhelpgenerator inside build work than setting these vars?

(about "Outdated") moved it to preBuild, question is still valid

(moved it to the buildPhase again, as preBuild version sometimes broke down when building with more than 3 --cores)

I'm not sure why setting QT_PLUGIN_PATH isn't sufficient, and it should be OK to set these in preBuild, but I don't see anything wrong with this.

stale · 2020-06-05T19:19:19Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

ttuegel · 2020-07-20T14:29:41Z

pkgs/applications/virtualization/spim/default.nix

+  buildPhase = ''
+    export QT_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}"
+    export QT_QPA_PLATFORM_PLUGIN_PATH="${qtbase.bin}/${qtbase.qtPluginPrefix}/platforms"
+    make


I'm not sure why setting QT_PLUGIN_PATH isn't sufficient, and it should be OK to set these in preBuild, but I don't see anything wrong with this.

ttuegel · 2020-07-20T14:31:37Z

pkgs/applications/virtualization/spim/default.nix

+
+  sourceRoot = "code-r${version}/QtSpim";
+
+  nativeBuildInputs = [ bison flex qmake ];


Please add wrapQtAppsHook to nativeBuildInputs.

prusnak · 2020-12-03T18:56:07Z

@aske do you still want to get this in?

aske · 2020-12-03T19:39:44Z

Yes, thank you for pinging. I’ll resolve conflicts and update PR soonish. (Not sure when I’ll have time to use the actual program though; added it in order to use while reading tiger book).

…

On 3 Dec 2020, at 21:56, Pavol Rusnak ***@***.***> wrote: @aske do you still want to get this in? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

eadwu · 2021-01-15T20:22:40Z

For 734, it at least worked a month or two ago when I was using it for my Computer Architecture course last semester.

commit 
Author: Edmund Wu
Date:   Sun Nov 22 13:42:27 2020 -0500

    qtspim: 722 -> 734

diff --git a/pkgs/applications/virtualization/spim/default.nix b/pkgs/applications/virtualization/spim/default.nix
index 07c94d84d5a..595f1e90789 100644
--- a/pkgs/applications/virtualization/spim/default.nix
+++ b/pkgs/applications/virtualization/spim/default.nix
@@ -1,35 +1,40 @@
-{ mkDerivation, lib, fetchsvn, qmake, qtbase, qttools, bison, flex }:
+{ lib, mkDerivation, fetchsvn
+, flex, bison, qmake, wrapQtAppsHook
+, qtbase, qttools }:
 
 mkDerivation rec {
   pname = "QtSpim";
-  version = "722";
+  version = "734";
 
   src = fetchsvn {
     url = "https://svn.code.sf.net/p/spimsimulator/code";
     rev = version;
-    sha256 = "1hfz41ra93pdd2pri5hibl63sg9yyk12a8nhdkmgj7h9bwgqxw6b";
+    sha256 = "1c2d30xi9jvxh34pd7m5mzgp14qz0s1726gryc7ny2z6sqdjqsaa";
   };
 
   sourceRoot = "code-r${version}/QtSpim";
 
-  nativeBuildInputs = [ bison flex qmake ];
+  nativeBuildInputs = [ flex bison qmake wrapQtAppsHook ];
 
   buildInputs = [ qtbase qttools ];
 
   # Remove build artifacts from the repo
   preConfigure = ''
-    rm parser_yacc.h
-    rm parser_yacc.cpp
-    rm scanner_lex.cpp
+    sed -i \
+      -e 's@$(COPY) ''${QMAKE_FILE_PATH}/''${QMAKE_FILE_BASE}.qhc ''${QMAKE_FILE_OUT};@@g' \
+      -e 's@qcollectiongenerator@qhelpgenerator@g' \
+      QtSpim.pro
+
+    sed -i \
+      -e 's/zero_imm/is_zero_imm/g' \
+      -e 's/^int data_dir/bool data_dir/g' \
+      -e 's/^int text_dir/bool text_dir/g' \
+      -e 's/^int parse_error_occurred/bool parse_error_occurred/g' \
+      parser_yacc.cpp
 
     rm help/qtspim.qhc
   '';
 
-  # Fix bug in a generated Makefile
-  postConfigure = ''
-    substituteInPlace Makefile --replace '$(MOVE) help/qtspim.qhc help/qtspim.qhc;' ""
-  '';
-
   # Fix documentation path
   postPatch = ''
     substituteInPlace menu.cpp --replace "/usr/lib/qtspim/help/qtspim.qhc" "$out/share/qtspim/help/qtspim.qhc"

hpfr · 2021-07-01T22:25:52Z

I was also able to get this working with eadwu's patch. Friendly ping to @aske in case you've got the bandwidth to get this in

SuperSandro2000 · 2021-07-05T21:25:15Z

pkgs/applications/virtualization/spim/default.nix

+    rm parser_yacc.h
+    rm parser_yacc.cpp
+    rm scanner_lex.cpp
+
+    rm help/qtspim.qhc


Suggested change

rm parser_yacc.h

rm parser_yacc.cpp

rm scanner_lex.cpp

rm help/qtspim.qhc

rm parser_yacc.h parser_yacc.cpp scanner_lex.cpp help/qtspim.qhc

SuperSandro2000 · 2021-07-05T21:25:29Z

pkgs/applications/virtualization/spim/default.nix

+    substituteInPlace menu.cpp --replace "/usr/lib/qtspim/help/qtspim.qhc" "$out/share/qtspim/help/qtspim.qhc"
+    substituteInPlace menu.cpp --replace "/usr/lib/qtspim/bin/assistant" "${qttools.dev}/bin/assistant"


Suggested change

substituteInPlace menu.cpp --replace "/usr/lib/qtspim/help/qtspim.qhc" "$out/share/qtspim/help/qtspim.qhc"

substituteInPlace menu.cpp --replace "/usr/lib/qtspim/bin/assistant" "${qttools.dev}/bin/assistant"

substituteInPlace menu.cpp \

--replace "/usr/lib/qtspim/help/qtspim.qhc" "$out/share/qtspim/help/qtspim.qhc" \

--replace "/usr/lib/qtspim/bin/assistant" "${qttools.dev}/bin/assistant"

stale · 2022-01-03T20:34:31Z

I marked this as stale due to inactivity. → More info

NickCao · 2023-01-26T00:09:56Z

superseded by #131325

ofborg bot added 8.has: documentation 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Dec 4, 2019

langston-barrett reviewed Dec 4, 2019

View reviewed changes

aske force-pushed the spim branch from c86c8da to 2e0e1b0 Compare December 5, 2019 09:29

ttuegel requested changes Dec 8, 2019

View reviewed changes

aske force-pushed the spim branch 3 times, most recently from 601f767 to 2cc7fba Compare December 8, 2019 16:09

aske commented Dec 8, 2019

View reviewed changes

ofborg bot removed the 8.has: documentation label Dec 8, 2019

aske force-pushed the spim branch 2 times, most recently from da9c842 to 047a586 Compare December 8, 2019 16:21

qtspim: init at 722

9a2f52e

aske force-pushed the spim branch from 047a586 to 9a2f52e Compare December 8, 2019 18:38

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2020

ttuegel approved these changes Jul 20, 2020

View reviewed changes

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2020

ttuegel reviewed Jul 20, 2020

View reviewed changes

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

prusnak added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 3, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 15, 2021

SuperSandro2000 reviewed Jul 5, 2021

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 3, 2022

Artturin added the 12.approvals: 1 label Apr 13, 2022

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 13, 2022

Artturin marked this pull request as draft May 1, 2022 23:06

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2022

NickCao closed this Jan 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qtspim: init at 722 #74999

qtspim: init at 722 #74999

aske commented Dec 4, 2019

langston-barrett Dec 4, 2019

aske Dec 5, 2019

ttuegel Dec 8, 2019

aske Dec 8, 2019

aske Dec 8, 2019

aske Dec 8, 2019 •

edited

aske Dec 8, 2019

ttuegel Jul 20, 2020

stale bot commented Jun 5, 2020

ttuegel Jul 20, 2020

ttuegel Jul 20, 2020

prusnak commented Dec 3, 2020

aske commented Dec 3, 2020 via email

eadwu commented Jan 15, 2021

hpfr commented Jul 1, 2021

SuperSandro2000 Jul 5, 2021

SuperSandro2000 Jul 5, 2021

stale bot commented Jan 3, 2022

NickCao commented Jan 26, 2023


		buildInputs = [ qtbase qttools ];

		# Remove build artefacts from the repo

	# Remove build artefacts from the repo
	# Remove build artifacts from the repo


		sourceRoot = "code-r${version}/QtSpim";

		nativeBuildInputs = [ bison flex qmake ];

		substituteInPlace menu.cpp --replace "/usr/lib/qtspim/help/qtspim.qhc" "$out/share/qtspim/help/qtspim.qhc"
		substituteInPlace menu.cpp --replace "/usr/lib/qtspim/bin/assistant" "${qttools.dev}/bin/assistant"

qtspim: init at 722 #74999

qtspim: init at 722 #74999

Conversation

aske commented Dec 4, 2019

Motivation for this change

Things done

Notify maintainers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aske Dec 8, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Jun 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prusnak commented Dec 3, 2020

aske commented Dec 3, 2020 via email

eadwu commented Jan 15, 2021

hpfr commented Jul 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Jan 3, 2022

NickCao commented Jan 26, 2023

aske Dec 8, 2019 •

edited