Portals: Block element.focus #20593
Merged
Portals: Block element.focus #20593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1940527
branch
7 times, most recently
from
0c9e6ef
to
888ce5c
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1940527
branch
from
888ce5c
to
8382229
Compare
Prevent elements inside a portal from getting focus by calling focus(). Design doc: https://docs.google.com/document/d/143rpT0pr9TnHY6qDJUpbNg9202E3Du2dsUWE4SHu5cQ/edit?usp=sharing Bug: 1030838 Change-Id: Ief104056daf9399e6e3d8763a00e292fd101deef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940527 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#725307}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1940527
branch
from
8382229
to
2081839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent elements inside a portal from getting focus by calling focus().
Design doc: https://docs.google.com/document/d/143rpT0pr9TnHY6qDJUpbNg9202E3Du2dsUWE4SHu5cQ/edit?usp=sharing
Bug: 1030838
Change-Id: Ief104056daf9399e6e3d8763a00e292fd101deef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940527
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#725307}