[Gecko Bug 1600078] webdriver: make test_alert_unsupported_operation Gecko specific #20594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic auth dialogues are not included in HTML's definition of 'user prompts': those are limited to the 'simple dialogues' such as window.alert(), window.prompt() et al. and the print dialogue. Since we don't want to regress this behaviour in geckodriver, this patch removes test_alert_unsupported_operation from WPT and makes it Mozilla-specific. The patch doesn't remove the basic auth framework code from WPT because it's assumed we will need that in WPT in the very near future. Thanks-to: Carlos Garcia Campos <cgarcia@igalia.com> Differential Revision: https://phabricator.services.mozilla.com/D55134 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600078 gecko-commit: c449c7ab372d876f4fd172462cc1f5609fe8c153 gecko-integration-branch: autoland gecko-reviewers: webdriver-reviewers, jgraham
wpt-pr-bot
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic auth dialogues are not included in HTML's definition of
'user prompts': those are limited to the 'simple dialogues' such
as window.alert(), window.prompt() et al. and the print dialogue.
Since we don't want to regress this behaviour in geckodriver, this
patch removes test_alert_unsupported_operation from WPT and makes
it Mozilla-specific.
The patch doesn't remove the basic auth framework code from WPT
because it's assumed we will need that in WPT in the very near future.
Thanks-to: Carlos Garcia Campos cgarcia@igalia.com
Differential Revision: https://phabricator.services.mozilla.com/D55134
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1600078
gecko-commit: c449c7ab372d876f4fd172462cc1f5609fe8c153
gecko-integration-branch: autoland
gecko-reviewers: webdriver-reviewers, jgraham