Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plplot: init at 5.15.0 #74989

Merged
merged 1 commit into from Jan 8, 2020
Merged

plplot: init at 5.15.0 #74989

merged 1 commit into from Jan 8, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

doronbehar
doronbehar requested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented.

doronbehar
doronbehar approved these changes Dec 6, 2019
View reviewed changes
pkgs/development/libraries/plplot/default.nix Outdated Show resolved Hide resolved
@marsam marsam merged commit 4d77c4a into NixOS:master Jan 8, 2020
@bcdarwin bcdarwin deleted the plplot branch January 8, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @doronbehar @marsam