Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: Update CRAN and bioconductor packages #75010

Closed
wants to merge 1 commit into from
Closed

R: Update CRAN and bioconductor packages #75010

wants to merge 1 commit into from

Conversation

jabranham
Copy link
Contributor

Motivation for this change

Update R package sets

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ran nix-build test-evaluation.nix --dry-run

Notify maintainers

cc @peti

@jabranham jabranham requested a review from peti as a code owner December 5, 2019 02:34
@peti
Copy link
Member

peti commented Dec 6, 2019

Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates. If those come out fine, then we can merge.

@jabranham
Copy link
Contributor Author

Looks like the build finished OK

@peti peti self-assigned this Dec 13, 2019
@peti
Copy link
Member

peti commented Dec 13, 2019

I've cherry-picked the R update from #75587 into r-updates, too. I'll merge later tonight, assuming that Hydra reveals no major disaster.

@peti peti closed this in b9a558a Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees

@peti peti

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jabranham @peti