Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildah: 1.11.5 -> 1.11.6 #75009

Merged
merged 1 commit into from Dec 5, 2019
Merged

buildah: 1.11.5 -> 1.11.6 #75009

merged 1 commit into from Dec 5, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 5, 2019

Motivation for this change

Changelog: https://github.com/containers/buildah/releases/tag/v1.11.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Profpatsch @vdemeester @saschagrunert

vdemeester
vdemeester approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

saschagrunert
saschagrunert approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just one question regarding the patch

pkgs/development/tools/buildah/default.nix
nativeBuildInputs = [ pkgconfig ];
buildInputs = [ gpgme libgpgerror lvm2 btrfs-progs ostree libselinux libseccomp ];

patches = [ ./disable-go-module-mode.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, do you think we can switch to buildGoModule without adding this patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer keep using buildGoPackage while possible, because buildGoModule abuses fixed-output derivations which may not be preferable NixOS/nix#2270

@marsam marsam merged commit f092ee6 into NixOS:master Dec 5, 2019
@marsam marsam deleted the update-buildah branch December 5, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @vdemeester @saschagrunert