gitolite: wrap gitolite-shell #75005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomberek
reviewed
Dec 5, 2019
git wasn't found when used with services.fcgiwrap for http auth
bbigras
force-pushed
the
fix-gitolite-shell
branch
from
bcdc276
to
a405b0c
Compare
|
@tomberek I did the changes and I added a test. It's my first one. |
bbigras
commented
Dec 5, 2019
| # turn off gzip as git objects are already well compressed | ||
| gzip off; | ||
|
|
||
| # use file based basic authentication |
There was a problem hiding this comment.
btw those comments were copy/pasted from some gist. I hope it's still fine.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/89 |
tomberek
approved these changes
Dec 8, 2019
Lassulus
approved these changes
Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git wasn't found when used with services.fcgiwrap
for http auth with nginx
Motivation for this change
I was trying to use gitolite with fcgiwrap and gitolite-shell woudln't find the git binary.
I thought of using
substituteInPlaceat first but there's a lot of "git" occurences that shouldn't be replaced in that script.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)/nix/store/mnf5qhaxyqvzmb5bp7h6zv03vhf3brh0-gitolite-3.6.11 81.6M
/nix/store/m1sg02d5yvazcf5hs4hxzpfybm209gnq-gitolite-3.6.11 226.4M
Is the size increase normal?
Notify maintainers
cc @thoughtpolice @Lassulus @tomberek