New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitolite: wrap gitolite-shell #75005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be out of date on the current best practice:
git can go in propagatedBuildInputs and makeWrapper can go in nativeBuildInputs
git wasn't found when used with services.fcgiwrap for http auth
bcdc276
to
a405b0c
Compare
@tomberek I did the changes and I added a test. It's my first one. |
# turn off gzip as git objects are already well compressed | ||
gzip off; | ||
|
||
# use file based basic authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw those comments were copy/pasted from some gist. I hope it's still fine.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the nixos test! This is awesome.
Builds and tests and functions fine. [NixOS]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with nix-review, ran the tests, LGTM
git wasn't found when used with services.fcgiwrap
for http auth with nginx
Motivation for this change
I was trying to use gitolite with fcgiwrap and gitolite-shell woudln't find the git binary.
I thought of using
substituteInPlace
at first but there's a lot of "git" occurences that shouldn't be replaced in that script.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)/nix/store/mnf5qhaxyqvzmb5bp7h6zv03vhf3brh0-gitolite-3.6.11 81.6M
/nix/store/m1sg02d5yvazcf5hs4hxzpfybm209gnq-gitolite-3.6.11 226.4M
Is the size increase normal?
Notify maintainers
cc @thoughtpolice @Lassulus @tomberek