Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md to reflect the introduction of issue templates #74928

Merged
merged 1 commit into from Dec 4, 2019
Merged

Update CONTRIBUTING.md to reflect the introduction of issue templates #74928

merged 1 commit into from Dec 4, 2019

Conversation

davidak
Copy link
Member

@davidak davidak commented Dec 3, 2019

Motivation for this change

to reflect the introduction of issue templates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Dec 3, 2019
View reviewed changes
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@davidak
Update CONTRIBUTING.md
cc4447d 
to reflect the introduction of issue templates
@worldofpeace worldofpeace merged commit fc09599 into NixOS:master Dec 4, 2019
@grahamc grahamc changed the title Update CONTRIBUTING.md Update CONTRIBUTING.md to reflect the introduction of issue templates Dec 4, 2019
@davidak davidak deleted the patch-2 branch December 4, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@jonringer jonringer jonringer approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidak @Lassulus @jonringer @c0bw3b @worldofpeace