Check active/previous interval when rescheduling after interval update #20589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2019
When nudging the presentation time back in InstanceListChanged(), the previous interval could be the active one, so we need to consider it when updating the active state and when compute the next interval time. Bug: 1030309 Change-Id: I5d20878f45dd4e26c5966c816b9ff5c82e4c40b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948938 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721129}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1948938
branch
from
f30e56d
to
4acb1ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nudging the presentation time back in InstanceListChanged(), the
previous interval could be the active one, so we need to consider it
when updating the active state and when compute the next interval time.
Bug: 1030309
Change-Id: I5d20878f45dd4e26c5966c816b9ff5c82e4c40b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948938
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#721129}