Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout" #20588

Merged
merged 1 commit into from Dec 4, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 3, 2019

This reverts commit 4fb5e9ecba28a18c69ef4736cce74664ae82af6a.

Reason for revert: Triggered DCHECK !constraint_space.IsIntermediateLayout() || box_->NeedsLayout()

Original change's description:

[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout

Bug: 635619
Change-Id: I6f7b1e16098a773aab2ac395b3b23e8b2af2b99e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920200
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716907}

TBR=cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 635619, 1027759
Change-Id: I961ca71602f331d2a612d430e9a4ae049e331b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948496
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721112}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

…yout"

This reverts commit 4fb5e9ecba28a18c69ef4736cce74664ae82af6a.

Reason for revert: Triggered DCHECK !constraint_space.IsIntermediateLayout() || box_->NeedsLayout()

Original change's description:
> [LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout
>
> Bug: 635619
> Change-Id: I6f7b1e16098a773aab2ac395b3b23e8b2af2b99e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920200
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Commit-Queue: David Grogan <dgrogan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#716907}

TBR=cbiesinger@chromium.org,dgrogan@chromium.org,mstensho@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 635619, 1027759
Change-Id: I961ca71602f331d2a612d430e9a4ae049e331b1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948496
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721112}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants