Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gpapi: disable for python2 #74930

Merged
merged 1 commit into from Dec 3, 2019
Merged

pythonPackages.gpapi: disable for python2 #74930

merged 1 commit into from Dec 3, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 3, 2019 •
edited

Motivation for this change

09c7ecc broke python2 build.

hydra jobs: https://hydra.nixos.org/eval/1558063#tabs-now-fail
hydra build log: https://hydra.nixos.org/build/107771619/nixlog/1

Uses shutil.which(), which was added in 3.3
No longer supports python2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
pythonPackages.gpapi: disable for python2
98a411d 
Uses shutil.which(), which was added in 3.3
No longer supports python2
@jonringer jonringer requested a review from Ma27 December 3, 2019 18:21
@jonringer jonringer requested a review from FRidh as a code owner December 3, 2019 18:21
@Ma27 Ma27 merged commit a6bf454 into NixOS:master Dec 3, 2019
@Ma27
Copy link
Member

Ma27 commented Dec 3, 2019

@jonringer thanks! (and sorry for breaking this 😅 )

@jonringer jonringer deleted the disable-gpapi branch December 3, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Ma27