Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: 0.18.0 -> 0.19.0 #74931

Merged
merged 2 commits into from Dec 3, 2019
Merged

fzf: 0.18.0 -> 0.19.0 #74931

merged 2 commits into from Dec 3, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 3, 2019 •
edited

Motivation for this change

https://github.com/junegunn/fzf/releases/tag/0.19.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/jgx7yrzxr4nrad35crwabc4ryiffkiqy-fzf-0.18.0	  32.9M
/nix/store/s9xwpq7q68lqq3bwfz9v42j47wxqfqaa-fzf-0.19.0	  33.0M

This change is Reviewable

@ofborg ofborg bot requested a review from kalbasit December 3, 2019 18:49
@Ma27 Ma27 merged commit 5de0ac6 into NixOS:master Dec 3, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 3, 2019
@Ma27 @dtzWill
Merge pull request NixOS#74931 from filalex77/fzf-0.19.0
882b902 
fzf: 0.18.0 -> 0.19.0
(cherry picked from commit 5de0ac6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Br1ght0ne @Ma27