Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Longtasks] Fix containerType and containerSrc in attribution #20595

Merged
merged 1 commit into from Dec 4, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Dec 3, 2019

This CL brings the longtasks API up to date with the recent changes on
w3c/longtasks#78. It also adds WPT tests for
those changes. The changes are:

  • containerType is "window", "iframe", "embed", etc. depending on the
    type of the culprit browsing context container.
  • containerSrc is now the 'data' attribute when the container is an
    <object>.

Change-Id: I06f661968778e3bec433a1bfe758b4604df01557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721258}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This CL brings the longtasks API up to date with the recent changes on
w3c/longtasks#78. It also adds WPT tests for
those changes. The changes are:

* containerType is "window", "iframe", "embed", etc. depending on the
type of the culprit browsing context container.
* containerSrc is now the 'data' attribute when the container is an
<object>.

Change-Id: I06f661968778e3bec433a1bfe758b4604df01557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721258}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants