Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run continuous Travis checks (edit: Make failing status more obvious?) #6776

Closed
qyearsley-zz opened this issue Aug 7, 2017 · 2 comments · Fixed by #20586
Closed

Run continuous Travis checks (edit: Make failing status more obvious?) #6776

qyearsley-zz opened this issue Aug 7, 2017 · 2 comments · Fixed by #20586

Comments

@qyearsley-zz
Copy link
Contributor

Right now I think it's possible to introduce lint failures (or Python unit test failures) by committing directly without Travis checks (example).

AFAICT, we're not currently continuously running these tests for the master branch, but I've seen for other GitHub repos that they can have a current build status indicator (https://docs.travis-ci.com/user/status-images/).

Is this right? If so, how hard is it to enable continuous runs for some things? (I imagine stability checks would take way too long, but lint and Python tests might be reasonable?)

@gsnedders @bobholt

@gsnedders
Copy link
Member

Right now I think it's possible to introduce lint failures (or Python unit test failures) by committing directly without Travis checks (example).

Admins can push without passing Travis checks, though we rarely do. We could potentially just require admins to pass Travis checks first? It's sufficiently rarely used it's unlikely to make much difference. @jgraham?

AFAICT, we're not currently continuously running these tests for the master branch, but I've seen for other GitHub repos that they can have a current build status indicator (https://docs.travis-ci.com/user/status-images/).

We do already run tests on master (indeed, it's the default Travis setup). We just rarely act on it failing. See https://travis-ci.org/w3c/web-platform-tests/branches.

@qyearsley-zz
Copy link
Contributor Author

Ah, neat! Do you think the reason why people don't act on it failing (which is rare) is partly because it's not obvious?

Maybe we could put the little build status badge thing on https://github.com/w3c/web-platform-tests/blob/master/README.md or maybe https://pulls.web-platform-tests.org/?

@qyearsley-zz qyearsley-zz changed the title Run continuous (not per-PR) Travis checks Run continuous Travis checks (edit: Make failing status more obvious?) Aug 10, 2017
@gsnedders gsnedders added infra and removed infra labels Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants