Test if we correctly strip request-body-headers for redirects #20596
Conversation
wpt-pr-bot
requested review from
annevk,
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
|
|
||
| promise_test(function(test) { | ||
| return fetch(url + urlParameters, requestInit).then(function(resp) { | ||
| let isPostEnded = (expectedMethod == "POST"); |
There was a problem hiding this comment.
It only ends if it's a 301/302/303, right?
There was a problem hiding this comment.
expectedMethod == "POST" implies it's not 301/302/303
We couldn't do redirecting from/to |
JuniorHsu
changed the title
|
After talk to @annevk, we still can send TESTING method for fetch() though it's a little bit weird. I don't test GET->GET redirection. Spec doesn't ask for removing header, but it's weird to have request-body-headers as well. |
There was a problem hiding this comment.
This looks good to me. I'd prefer asserting actual values where possible and I'd also like the Content-Length test you had before to be reinstated. Even though developers cannot set Content-Length, it still seems good to test that it's properly reset by browsers during redirects. What do you think?
There was a problem hiding this comment.
This looks good to me. I'd prefer asserting actual values where possible and I'd also like the
Content-Lengthtest you had before to be reinstated. Even though developers cannot setContent-Length, it still seems good to test that it's properly reset by browsers during redirects. What do you think?
Yeah, let's take Content-Length into account
Issue: whatwg/fetch#609
Spec change: whatwg/fetch#977