Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openorienteering-mapper: 0.9.0 -> 0.9.1 #75036

Merged
merged 1 commit into from Dec 21, 2019
Merged

openorienteering-mapper: 0.9.0 -> 0.9.1 #75036

merged 1 commit into from Dec 21, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Dec 5, 2019 •
edited

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/9ggwghaaxisd3cjk4iniwrmjdkq1paxj-OpenOrienteering-Mapper-0.9.0
/nix/store/9ggwghaaxisd3cjk4iniwrmjdkq1paxj-OpenOrienteering-Mapper-0.9.0	 663.9M
$ nix path-info -Sh /nix/store/kdx140kwf9xx7hkzd1502sqk025y69if-OpenOrienteering-Mapper-0.9.1
/nix/store/kdx140kwf9xx7hkzd1502sqk025y69if-OpenOrienteering-Mapper-0.9.1	 664.4M
Notify maintainers

cc @mpickering

@teto
Copy link
Member

teto commented Dec 5, 2019

why ofborg didn't build on darwin ?

@sikmir
Copy link
Member Author

sikmir commented Dec 18, 2019

why ofborg didn't build on darwin ?

What's up with darwin?

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 21, 2019

Darwin builds on ofBorg builders are a different trust level.

@GrahamcOfBorg build openorienteering-mapper

c0bw3b
c0bw3b approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 75036 1

1 package were build:
  • openorienteering-mapper

Builds and runs on NixOS

@c0bw3b c0bw3b merged commit 013e439 into NixOS:master Dec 21, 2019
@sikmir sikmir deleted the oom branch December 22, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @teto @c0bw3b