Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.1 #2390

Merged
merged 3 commits into from
Dec 7, 2019
Merged

1.8.1 #2390

merged 3 commits into from
Dec 7, 2019

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Dec 3, 2019

Note: in order to build this pull request, the following 1.8.1 DLLs need to be in KSP Assemblies\1.8.1:

Assembly-CSharp.dll
UnityEngine.CoreModule.dll
UnityEngine.dll
UnityEngine.ImageConversionModule.dll
UnityEngine.IMGUIModule.dll
UnityEngine.InputLegacyModule.dll
UnityEngine.PhysicsModule.dll
UnityEngine.TextRenderingModule.dll
UnityEngine.UI.dll

@@ -4,10 +4,14 @@

namespace System.Runtime.CompilerServices {

#if KSP_VERSION_1_7_3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to those in 1.8.1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments above:

// Pretend that we have the caller file path and line number attributes, even
// though they do not exist in .NET 3.5; since this is actually substituted
// at compile time it will work as intended.

They are in the .NET Framework 4.5 and later, so they are there; we don't need to pretend that they are.

@pleroy pleroy added the LGTM label Dec 7, 2019
@eggrobin eggrobin merged commit fa227ca into mockingbirdnest:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants