Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nnn: 2.7 -> 2.8.1 #74971

Closed
wants to merge 4 commits into from
Closed

nnn: 2.7 -> 2.8.1 #74971

wants to merge 4 commits into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 4, 2019 •
edited

Motivation for this change

https://github.com/jarun/nnn/releases/tag/v2.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/vm8l0is87p446jrd0wsngmd35jj3q9da-nnn-2.7	  30.6M
/nix/store/491kv7bsd1g0blkhklcm8fc329kqhmbj-nnn-2.8	  30.7M
Notify maintainers

cc @jfrankenau

This change is Reviewable

@ofborg ofborg bot requested a review from jfrankenau December 4, 2019 11:08
@sikmir
Copy link
Member

sikmir commented Dec 4, 2019

@filalex77 2.8.1 is out.

@Br1ght0ne Br1ght0ne changed the title nnn: 2.7 -> 2.8 nnn: 2.7 -> 2.8.1 Dec 5, 2019
@Br1ght0ne
Copy link
Member Author

@GrahamcOfBorg build nnn

@jfrankenau
Copy link
Member

This update has already been merged in #75016. Also this pull request contains some totally unrelated changes.

@Br1ght0ne
Copy link
Member Author

@jfrankenau Oh, didn't know about that. Thanks for letting me know!

@Br1ght0ne Br1ght0ne closed this Dec 5, 2019
@Br1ght0ne Br1ght0ne deleted the nnn-2.8 branch December 5, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @sikmir @jfrankenau