oq: init at 1.0.2 #75042

Br1ght0ne · 2019-12-05T10:57:11Z

Motivation for this change

https://github.com/Blacksmoke16/oq/releases/tag/v1.0.2

Things done

This change is

stigtsp

Things tested:

Builds on x86_64-linux (NixOS) OK
Tested basic usage of oq binary : Fails at parsing xml:

echo -e "person:\n name: Sandy\n number: 42\n" | ./oq/bin/oq -i yaml -o xml --xml-root person .person | ./oq/bin/oq -i xml -o json
Invalid input format: 'xml'
Failed to raise an exception: END_OF_STACK
[0x456bd6] ???
[0x4077fb] __crystal_raise +43
[0x420525] ???
[0x40a2b3] main +147
[0x7f225f1b8b8e] __libc_start_main +238
[0x40483a] _start +42
[0x0] ???

Result of nix-review pr 75042 1

1 package were build:

oq

Br1ght0ne · 2019-12-05T15:52:40Z

@stigtsp I think that XML deserialization is implemented in Blacksmoke16/oq@960e10e, which was later than the last release. Help text doesn't reflect the actual capabilities at the moment of the release.

When the new release comes out, I'll update it.

stigtsp

oq fails to build on darwin. Not sure how critical this is, One option is setting meta.platform = plaforms.linux.

Tested on a local darwin build box, which gave the following output


$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /Users/user/.cache/nix-review/pr-75042/build.nix
builder for '/nix/store/ixr2816qj3jinmx817i14affjqcf6awz-crystal-0.30.1.drv' failed with exit code 2; last 10 log lines:
  Using /nix/store/g8w64ax6s3lzv1kpwq38r1cgpayxqh7k-llvm-6.0.1/bin/llvm-config [version=6.0.1]
  clang++ -c  -o src/llvm/ext/llvm_ext.o src/llvm/ext/llvm_ext.cc -I/nix/store/g8w64ax6s3lzv1kpwq38r1cgpayxqh7k-llvm-6.0.1/include  -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -O3 -DNDEBUG  -fno-exceptions -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
  ./bin/crystal docs -b https://crystal-lang.org/api/latest src/docs_main.cr
  make: Nothing to be done for 'docs'.
  clang -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
  ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
  CRYSTAL_CONFIG_PATH="/private/var/folders/g1/y968ywwx2s9c016g26_dbpcm0000gn/T/nix-build-crystal-0.30.1.drv-0/source/src" CRYSTAL_CONFIG_LIBRARY_PATH="/nix/store/ikhr2c3zqdjljry2y9rhwc0k1z8k1iy5-crystal-0.30.1/lib/crystal:/nix/store/pr6crirn4s0bamk4ygh8mddz8kb95dw0-crystal-binary-0.29.0/embedded/lib" CRYSTAL_CONFIG_BUILD_COMMIT="" ./bin/crystal build --release --single-module -D preview_overflow -D compiler_rt  -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
  Assertion failed: (cast<DISubprogram>(Scope)->describes(MF->getFunction())), function getOrCreateRegularScope, file /var/cache/omnibus/src/llvm/llvm-3.9.1.src/lib/CodeGen/LexicalScopes.cpp, line 159.
  /nix/store/pr6crirn4s0bamk4ygh8mddz8kb95dw0-crystal-binary-0.29.0/bin/crystal: line 103: 17491 Abort trap: 6           "$INSTALL_DIR/embedded/bin/crystal" "$@"
  make: *** [Makefile:132: .build/crystal] Error 134
cannot build derivation '/nix/store/4qgjmgazkd159wd4ihjfnhybxn71ich2-crystal-0.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v9kycmclaglmdi9i375qc6i5w59s2a2k-oq-0.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qncdf8xv0xnr1pwf6v0ksfn2f90cra12-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 160 copied (1734.3 MiB), 342.9 MiB DL]
error: build of '/nix/store/qncdf8xv0xnr1pwf6v0ksfn2f90cra12-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75042
1 package failed to build:
oq

pkgs/development/tools/oq/default.nix

stigtsp

It seems a wrapper is needed for oq to find jq when it's not in the environments path. I've added code suggestions.

pkgs/development/tools/oq/default.nix

Br1ght0ne · 2019-12-05T21:46:51Z

@stigtsp Thanks a lot for your help! I'm still learning these things.

stigtsp

Looks good to me

Result of nix-review pr 75042 1

1 package were build:

oq

Br1ght0ne · 2019-12-19T13:37:08Z

@stigtsp Is anything impeding this PR from being merged?

stigtsp · 2019-12-19T20:34:16Z

@stigtsp Is anything impeding this PR from being merged?

Not AFAIK, need someone with merge access to review.

stigtsp · 2019-12-19T20:36:26Z

@filalex77 Version 1.0.0 has been released, consider bumping to this version.

stigtsp

Update to 1.0.2 tested with:

$ echo -e "person:\n name: Sandy\n number: 42\n" | ./oq -i yaml -o xml --xml-root person .person | ./oq -i xml -o json | ./oq .person.number
"42"

Also needs a rebase

stigtsp · 2020-04-19T16:39:01Z

pkgs/development/tools/oq/default.nix

+
+crystal.buildCrystalPackage rec {
+  pname = "oq";
+  version = "0.2.1";


Suggested change

version = "0.2.1";

version = "1.0.2";

stigtsp · 2020-04-19T16:39:23Z

pkgs/development/tools/oq/default.nix

+    owner = "Blacksmoke16";
+    repo = pname;
+    rev = "v${version}";
+    sha256 = "0wc1wdvqybgybq09dr78b93mdyvr7avya5w8kffbv8p4i9yyrfn4";


Suggested change

sha256 = "0wc1wdvqybgybq09dr78b93mdyvr7avya5w8kffbv8p4i9yyrfn4";

sha256 = "0sf6rb5b6g7gzyq11l5868p3a1s5z8432swlpv457bfbbnbg6j6q";

Br1ght0ne · 2020-04-20T11:10:58Z

@GrahamcOfBorg eval

stigtsp

Looks good to me

Result of nixpkgs-review pr 75042 1

1 package built:

oq

stigtsp · 2020-04-20T14:23:20Z

Cc @etu

etu · 2020-05-10T08:45:27Z

Looks reasonable enough, thanks @stigtsp 🙂

stigtsp · 2020-05-10T13:15:21Z

@filalex77 thx for the pr

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 5, 2019

stigtsp reviewed Dec 5, 2019

View reviewed changes

Br1ght0ne force-pushed the oq-0.2.1 branch from 7ac28be to 5af35d4 Compare December 5, 2019 16:34

Br1ght0ne requested a review from stigtsp December 5, 2019 16:34

ofborg bot added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Dec 5, 2019

stigtsp reviewed Dec 5, 2019

View reviewed changes

pkgs/development/tools/oq/default.nix Outdated Show resolved Hide resolved

Br1ght0ne force-pushed the oq-0.2.1 branch 2 times, most recently from 9c5453c to ec44c1c Compare December 5, 2019 20:35

stigtsp requested changes Dec 5, 2019

View reviewed changes

pkgs/development/tools/oq/default.nix Outdated Show resolved Hide resolved

pkgs/development/tools/oq/default.nix Show resolved Hide resolved

pkgs/development/tools/oq/default.nix Show resolved Hide resolved

Br1ght0ne force-pushed the oq-0.2.1 branch from ec44c1c to a5db6ef Compare December 5, 2019 21:46

Br1ght0ne requested a review from stigtsp December 5, 2019 21:47

stigtsp approved these changes Dec 5, 2019

View reviewed changes

stigtsp reviewed Apr 19, 2020

View reviewed changes

oq: init at 1.0.2

c28f6fc

Br1ght0ne force-pushed the oq-0.2.1 branch from a5db6ef to c28f6fc Compare April 20, 2020 11:08

Br1ght0ne changed the title ~~oq: init at 0.2.1~~ oq: init at 1.0.2 Apr 20, 2020

Br1ght0ne requested a review from stigtsp April 20, 2020 11:11

ofborg bot added the 10.rebuild-linux: 1 label Apr 20, 2020

stigtsp approved these changes Apr 20, 2020

View reviewed changes

stigtsp requested a review from etu May 6, 2020 13:28

etu merged commit 192c150 into NixOS:master May 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oq: init at 1.0.2 #75042

oq: init at 1.0.2 #75042

Br1ght0ne commented Dec 5, 2019 •

edited

stigtsp left a comment •

edited

Br1ght0ne commented Dec 5, 2019

stigtsp left a comment •

edited

stigtsp left a comment

Br1ght0ne commented Dec 5, 2019

stigtsp left a comment

Br1ght0ne commented Dec 19, 2019

stigtsp commented Dec 19, 2019

stigtsp commented Dec 19, 2019 •

edited

stigtsp left a comment •

edited

stigtsp Apr 19, 2020

stigtsp Apr 19, 2020

Br1ght0ne commented Apr 20, 2020

stigtsp left a comment

stigtsp commented Apr 20, 2020

etu commented May 10, 2020

stigtsp commented May 10, 2020

	sha256 = "0wc1wdvqybgybq09dr78b93mdyvr7avya5w8kffbv8p4i9yyrfn4";
	sha256 = "0sf6rb5b6g7gzyq11l5868p3a1s5z8432swlpv457bfbbnbg6j6q";

oq: init at 1.0.2 #75042

oq: init at 1.0.2 #75042

Conversation

Br1ght0ne commented Dec 5, 2019 • edited

Motivation for this change

Things done

stigtsp left a comment • edited

Choose a reason for hiding this comment

Br1ght0ne commented Dec 5, 2019

stigtsp left a comment • edited

Choose a reason for hiding this comment

stigtsp left a comment

Choose a reason for hiding this comment

Br1ght0ne commented Dec 5, 2019

stigtsp left a comment

Choose a reason for hiding this comment

Br1ght0ne commented Dec 19, 2019

stigtsp commented Dec 19, 2019

stigtsp commented Dec 19, 2019 • edited

stigtsp left a comment • edited

Choose a reason for hiding this comment

stigtsp Apr 19, 2020

Choose a reason for hiding this comment

stigtsp Apr 19, 2020

Choose a reason for hiding this comment

Br1ght0ne commented Apr 20, 2020

stigtsp left a comment

Choose a reason for hiding this comment

stigtsp commented Apr 20, 2020

etu commented May 10, 2020

stigtsp commented May 10, 2020

Br1ght0ne commented Dec 5, 2019 •

edited

stigtsp left a comment •

edited

stigtsp left a comment •

edited

stigtsp commented Dec 19, 2019 •

edited

stigtsp left a comment •

edited