Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: cleanups #75043

Merged
merged 3 commits into from Dec 11, 2019
Merged

webkitgtk: cleanups #75043

merged 3 commits into from Dec 11, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Dec 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace changed the title webkitgtk: enableParallelBuilding webkitgtk: cleanups Dec 5, 2019
@worldofpeace
Copy link
Contributor Author

@pbogdan ok soo... We'll just pretend that didn't happen 😄

Some weeks it's like this.

@worldofpeace worldofpeace merged commit 58cf77f into NixOS:master Dec 11, 2019
@worldofpeace worldofpeace deleted the webkitgtk-parallel branch December 11, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan pbogdan left review comments

@jtojnar jtojnar jtojnar left review comments

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @pbogdan @jtojnar